jayden/nova-engine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use std::string when setting Window title instead of std::string_view

Browse Source
This commit is contained in:
Jayden Grubb
2025-09-07 00:45:12 +10:00
committed by Jayden Grubb
parent 829a00bab8
commit ba30cc49d5
3 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
engine/include/nova/platform/window_driver.h
View File

@@ -11,7 +11,7 @@
#include <nova/render/render_structs.h>
#include <nova/types.h>
#include <string_view>
#include <string>
namespace Nova {
class RenderDriver;
@@ -30,10 +30,10 @@ namespace Nova {
virtual void beep() = 0;
virtual u32 get_window_count() const = 0;
[[nodiscard]] virtual WindowID create_window(std::string_view title, u32 width, u32 height) = 0;
[[nodiscard]] virtual WindowID create_window(const std::string& title, u32 width, u32 height) = 0;
virtual void destroy_window(WindowID window) = 0;
virtual void set_window_title(WindowID window, std::string_view title) = 0;
virtual void set_window_title(WindowID window, const std::string& title) = 0;
virtual void set_window_size(WindowID window, u32 width, u32 height) = 0;
virtual void set_window_position(WindowID window, i32 x, i32 y) = 0;