jayden/nova-engine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use [[nodiscard]] attribute more sparingly

Browse Source 
Removed all uses of the [[nodiscard]] attribute unless ignoring the
return value would lead to an error or leak e.g. memory allocations.
This commit is contained in:
Jayden Grubb
2025-06-26 20:28:21 +10:00
parent d89f8de08f
commit 04eec1b703
4 changed files with 30 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
engine/src/platform/linux/x11/window_driver.h
View File

@@ -31,13 +31,13 @@ namespace Nova {
X11WindowDriver();
~X11WindowDriver() override;
[[nodiscard]] WindowAPI get_api() const override;
[[nodiscard]] std::string get_api_name() const override;
WindowAPI get_api() const override;
std::string get_api_name() const override;
void poll_events() override;
void beep() override;
[[nodiscard]] u32 get_window_count() const override;
u32 get_window_count() const override;
[[nodiscard]] WindowID create_window(std::string_view title, u32 width, u32 height) override;
void destroy_window(WindowID window) override;
@@ -45,7 +45,7 @@ namespace Nova {
void set_window_size(WindowID window, u32 width, u32 height) override;
void set_window_position(WindowID window, i32 x, i32 y) override;
[[nodiscard]] const char* get_surface_extension() const override;
const char* get_surface_extension() const override;
[[nodiscard]] SurfaceID create_surface(WindowID window, RenderDriver* driver) override;
private: